C#: Use feed management in the remaining restore flows. - #22041
Open
michaelnebel wants to merge 10 commits into
Open
C#: Use feed management in the remaining restore flows.#22041michaelnebel wants to merge 10 commits into
michaelnebel wants to merge 10 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
from
June 24, 2026 10:58
25ade27 to
afe8f07
Compare
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
5 times, most recently
from
June 24, 2026 13:47
29a859a to
036f75c
Compare
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
from
June 25, 2026 11:06
036f75c to
86fc08e
Compare
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
3 times, most recently
from
June 30, 2026 13:05
4690d92 to
6ee50ce
Compare
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
from
June 30, 2026 14:21
43aaec6 to
fde527a
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
2 times, most recently
from
July 17, 2026 13:19
bbc01c9 to
b0eaf49
Compare
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
from
August 11, 2026 11:56
b0eaf49 to
a66f82e
Compare
…apsulate as immutable hash sets.
…mmutable hash sets).
…lays the calculation of the reachable feeds until it is needed/used.
…mSpecificFeeds as it is always called with this argument.
…instead of a specific nuget.config file, and supply a list of nuget sources when using the TryRestore.
michaelnebel
force-pushed
the
csharp/morefeedmanageruses
branch
from
August 12, 2026 12:31
a66f82e to
b34fe44
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes NuGet feed selection in FeedManager across remaining C# dependency restore flows.
Changes:
- Adds lazy feed discovery and reachability management.
- Passes feeds directly to restore commands.
- Removes fallback
nuget.configgeneration.
Show a summary per file
| File | Description |
|---|---|
2026-07-17-nuget-package-restore.md |
Documents restore changes. |
Semmle.Extraction.Tests/DotNet.cs |
Updates restore argument tests. |
PackagesConfigRestorer.cs |
Uses managed feed selection. |
NugetPackageRestorer.cs |
Migrates remaining restore flows. |
IDotNet.cs |
Removes config-path setting. |
FeedManager.cs |
Centralizes feed state and reachability. |
DotNet.cs |
Removes --configfile handling. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs:324
- The newly introduced unchecked-feed fallback is not exercised by the existing fallback integration tests; they all leave responsiveness checking enabled. Please add coverage that disables feed checking and verifies a missing package is restored through
AllFeeds, including the intended configured/private-feed behavior.
else
{
feeds = feedManager.AllFeeds;
}
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to use the newly introduced feed manager in more of the package restore flows.
To achieve this we are
DowloadMissingPackages. This also somewhat simplifies the restore logic as we no longer create a dedicatednuget.configfile in fallback scenarios, but instead we supply feeds directly via the command line. Furthermore, if NuGet feed responsiveness checking is disabled we use all feeds when attempting to download missing packages (this will include private registries as well).TryRestoremethod, which can be used to restore individual packages. The logic has been changed slightly here compared to earlier as we will attempt to use the feeds detected in the source directory (instead of those in the temporary directory).With the changes in this PR, all
restorelike flows specify the feeds directly via the command line (unless NuGet feed checking is disabled and no private registries are configured). That is, as a follow up we can attempt the remove the timeout fallback and instead just always use reachable feeds.Testing